Skip to content

Use NOCK_ENV=replay by default #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geigerzaehler
Copy link
Contributor

Replaying HTTP requests makes the tests faster and aligns them with CI.

I only realized quite late that the tests get a lot faster so I thought it would be a good idea to make that the default.

Replaying HTTP requests makes the tests faster and aligns them with CI.
@geigerzaehler
Copy link
Contributor Author

Could I get some feedback on this?

@aduh95
Copy link
Contributor

aduh95 commented Apr 4, 2025

I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality. Is it so bad to have to set the variable manually / go through the network?

@geigerzaehler
Copy link
Contributor Author

I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality.

I don’t see an issue with this. This is test code and people will expect mocks, etc. that don’t match reality. Right now the default behavior does not match what is run on CI, which is worse, I think. I was very confused when my tests where failing on CI but not locally. Using the recording is also faster and more reliable for for local development.

Is it so bad to have to set the variable manually / go through the network?
Of course it’s easy to set the environment variable. But this is nowhere documented for new contributors and even I sometimes forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants